Fix eval concurrency argument compatibility - #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix accuracy evaluation failures caused by passing the unsupported
--concurrent-requestsargument to InferenceXrun_eval, while ensuringaccuracy artifacts are reliably persisted for both local and remote evaluation.
Changes
EVAL_CONCURRENT_REQUESTS.MAGPIE_EVAL_CONCURRENCYto control accuracy concurrency independentlyfrom performance benchmark concurrency.
scripts on MI300X and MI355X.
MAGPIE_EVAL_CONCURRENCYEVAL_CONCURRENT_REQUESTSCONClm_eval/.accuracy_report.jsonbesidebenchmark_report.json.EVAL_CONCURRENT_REQUESTS="2 4"without losing staged results.meta_env.json, rather than theperformance benchmark concurrency.
of reporting a false success.
workspace.
Output
When accuracy evaluation is enabled, the benchmark workspace now includes: