Add persistent benchmark server reuse - #93
Merged
Merged
Conversation
haofrank
requested a deployment
to
mi355x-benchmark
September 9, 2026 21:07 — with
GitHub Actions
Waiting
sinarafati-amd
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Model sweeps often run several client configurations against the same inference server configuration. Restarting and reloading the model for every concurrency point adds substantial overhead and may introduce differences in server initialization. This change allows compatible benchmark invocations to share one warmed server while keeping lifecycle ownership and cleanup inside Magpie.
Validation
156 passedacross the benchmark lifecycle, benchmark support, and launcher compatibility testsUsage
Set
benchmark.server_lifecycle.enabled: true, keepcleanup: falsefor intermediate client runs, and setcleanup: truefor the final run. Client-only fields such as concurrency and sequence lengths may change; incompatible server-side configuration is rejected unless reuse is explicitly forced.