Enable AMD-AGI/TraceLens to reproduce minimal tests required by amd/skills - #1000
Open
danielholanda wants to merge 24 commits into
Open
Enable AMD-AGI/TraceLens to reproduce minimal tests required by amd/skills#1000danielholanda wants to merge 24 commits into
AMD-AGI/TraceLens to reproduce minimal tests required by amd/skills#1000danielholanda wants to merge 24 commits into
Conversation
Add evals to TraceLens skill
Replace the interpolated gemm-01-repeatability prompt with a self-contained one that fetches and unpacks the standalone unit-test trace itself, widen the expected artifact list, add an executive-summary behavior expectation, and drop the hooks.py clone/venv setup the new prompt no longer needs. Co-authored-by: Daniel Holanda <holand.daniel@gmail.com>
* Match the skill's frontmatter name to its folder The Agent Skills format requires `name` to equal the directory name, and skillscope's structural check fails on the mismatch. Federation into amd/skills rewrites the name to the `as:` value, so the catalog copy stays `tracelens-analysis-orchestrator`. Co-authored-by: Daniel Holanda <holand.daniel@gmail.com> * Add skillscope skill-evals workflow Runs the structural, routing, and behavior evals for TraceLens/Agent/Analysis/skills against danielholanda/skillscope. Co-authored-by: Daniel Holanda <holand.daniel@gmail.com> * Name the skill in skill-evals instead of deriving it Drops the SKILL_GLOBS indirection and `--routing-skills all` in favour of naming analysis-orchestrator where the choice is made, which also makes the routing comment unnecessary. Co-authored-by: Daniel Holanda <holand.daniel@gmail.com> * Point skill-evals at the skill folder rather than a glob Naming the one skill makes the behavior job's --skill redundant, so it goes too; --routing-skills stays because routing has no default. Co-authored-by: Daniel Holanda <holand.daniel@gmail.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Routing and behavioral are commands now, not modes of `run`. A single-skill repo also no longer has to name its routing set, so the args lines go away. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Use reusable workflow
Point to upstream repo
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add options to dispatchable workflow
Use Checkboxes in dispatchable workflow
danielholanda
changed the title
amd/skillscopeAMD-AGI/TraceLens to reproduce minimal tests required by amd/skills
danielholanda
commented
Sep 3, 2026
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| name: tracelens-analysis-orchestrator | |||
Author
There was a problem hiding this comment.
Same comment as in the PR description:
This PR also ensures that the skill name and the folder name match each other. This is in general a good practice as some tools do expect those names to match. Please also note that this could also be solved by changing the folder name instead of the skill name. When importing it to AMD Skills we are still importing it as tracelens-analysis-orchestrator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable
AMD-AGI/TraceLensto reproduce minimal tests required byamd/skillsDetails
This PR:
AMD-AGI/TraceLensbecomes the single source of truth).AMD-AGI/TraceLensto run this minimal set of tests easily to validate functionality before merging into the AMD-skills repo.Note: This PR also ensures that the skill name and the folder name match each other. This is in general a good practice as some tools do expect those names to match. Please also note that this could also be solved by changing the folder name instead of the skill name. When importing it to
AMD Skillswe are still importing it astracelens-analysis-orchestrator.With those changes,
AMD-AGI/TraceLensbecomes the single source of truth for thetracelens-analysis-orchestratorskill.