Conversation
vLLM compute_logits and similar post-step work sit after the execute_* envelope; bounding the CPU window by the next matching annotation keeps lm_head GEMMs without leaking the following step. Co-authored-by: Cursor <cursoragent@cursor.com>
ajassani
requested review from
devalshahamd,
gabeweisz and
tsrikris
as code owners
September 10, 2026 22:33
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gabeweisz
requested changes
Sep 10, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
gabeweisz
self-requested a review
September 11, 2026 17:07
gabeweisz
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts..ts+dur). Serving stacks launch work after that envelope and before the next step — vLLMcompute_logits/ lm_head GEMMs are the usual example — so those ops never made it into the extracted trace or GEMM tables.execute_*(Qwen3-0.6B/8B/14B, Llama-3.1-8B). Other vLLM configs can still keep vocab GEMMs in the split report. SGLang in-graph lm_head is a separate--capture_folderissue.Fixes #1023
Test plan
pytest tests/test_split_inference_trace_annotation.pycompute_logits/ vocab-sized GEMMs appear in the extracted window and GEMM sheetstep[DECODE|EXTEND]windows