TraceIndex: query roofline bound and utilization as typed columns - #1025
Open
ajassani wants to merge 2 commits into
Open
TraceIndex: query roofline bound and utilization as typed columns#1025ajassani wants to merge 2 commits into
ajassani wants to merge 2 commits into
Conversation
Filter bound and Pct Roofline without json_extract, and backfill existing SQLite catalogs from raw_row_json. Co-authored-by: Cursor <cursoragent@cursor.com>
ajassani
force-pushed
the
ajassani/traceindex-roofline-columns
branch
from
September 11, 2026 19:06
c47ff35 to
b332162
Compare
ajassani
requested review from
Ahmedhasssan-aig,
devalshahamd,
spandoesai and
tsrikris
as code owners
September 11, 2026 19:06
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pct Roofline_*,Roofline Bound,Roofline Time, andPercentage (%)fromunified_perf_summary.csvinto typedunified_perf_rowscolumns (pct_roofline_*,roofline_bound,roofline_time_us,gpu_kernel_pct).ALTER TABLEplusUPDATEfromraw_row_json. New imports write the columns directly.NULL, soWHERE pct_roofline_mean < 40only hits rows that actually have a roofline.Test plan
pytest tests/test_trace_index.pyTraceLens_trace_indexand confirmPRAGMA table_info(unified_perf_rows)includes the new columnsSELECT roofline_bound, COUNT(*), AVG(pct_roofline_mean) FROM unified_perf_rows WHERE roofline_bound IS NOT NULL GROUP BY 1Made with Cursor