Remove libdwarf headers from logduration install#36
Draft
Conversation
kerneldb copies system libdwarf headers into the kerneldb include directory as a workaround. This adds a post-install step that removes them: libdwarf is a system dependency that consumers should install via their package manager (libdwarf-dev / libdwarf-devel). The find_path(LIBDWARF_INCLUDE_DIR) in src/CMakeLists.txt already locates libdwarf headers at build time without bundling them. Co-authored-by: rwvo <21990117+rwvo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove libdwarf headers from logduration install
Remove libdwarf headers from logduration install
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kerneldbcopies system libdwarf headers into its install include directory so downstream builds can find them — a workaround that bundles a system dependency into the logduration install package.Changes
CMakeLists.txt: Adds a post-install step that removes the libdwarf headers kerneldb copies intoinclude/kerneldb/. Thefind_path(LIBDWARF_INCLUDE_DIR)insrc/CMakeLists.txtalready handles locating system libdwarf headers at build time, so bundling them is unnecessary.The glob path (
${LIBDWARF_INCLUDE_DIR}) is baked in at configure time, matching exactly what kerneldb copied and covering distro-specific layouts (e.g.libdwarf-0/on Ubuntu vslibdwarf/on RHEL).Note
The root cause lives in
external/kerneldb/src/CMakeLists.txt— theinstall(DIRECTORY ${LIBDWARF_INCLUDE_DIR}/ ...)block should be removed there in a follow-up PR to the kerneldb repo, at which point this workaround can be dropped.Original prompt
libdwarfheaders from logduration install #15📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.