Redo Data Access dumps according to the new spec#613
Open
amrc-benmorrow wants to merge 9 commits intomainfrom
Open
Redo Data Access dumps according to the new spec#613amrc-benmorrow wants to merge 9 commits intomainfrom
amrc-benmorrow wants to merge 9 commits intomainfrom
Conversation
_Sparkplug Device_ is no longer to be incorporated into the _Dataset_ class tree. Instead we have _Sparkplug dataset_ (R2) which references a _Sparkplug Device_ (still R1) via a _Sparkplug source_ app. Include a new permission and the Special which was omitted from the spec diagrams and so got missed.
Remove nnecessary capitals, they don't improve readability. Give a little more context for some names where they are likely to be used as primary classes and so need to be comprehensible entirely on their own.
We need a target to know what to grant both singular and plural grants on. The `null` option is a special-case shortcut for a Wildcard grant, because they're so common.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the commits from #606 which have been reverted by #612 and makes the changes needed by the new spec.
Most significantly, Sparkplug Device is no longer brought into the Dataset class tree; instead we have Sparkplug dataset which references a Sparkplug Device or Node. This means Sparkplug Device can stay rank 1 and models the source of the data rather than the data itself.