Skip to content

Fix single precision overflow issues with EB #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asalmgren merged 1 commit into from
Sep 14, 2026
Merged

Fix single precision overflow issues with EB #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/diffusion/DiffusionTensorOp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,9 @@ void DiffusionTensorOp::compute_divtau (Vector<MultiFab*> const& a_divtau,
AMREX_SPACEDIM, 1, MFInfo(),
a_velocity[lev]->Factory());
MultiFab::Copy(velocity[lev], *a_velocity[lev], 0, 0, AMREX_SPACEDIM, 1);
#ifdef AMREX_USE_EB
EB_set_covered(velocity[lev], 0, AMREX_SPACEDIM, 1, Real(0.0));
#endif
}

#ifdef AMREX_USE_EB
Expand Down
2 changes: 2 additions & 0 deletions src/diffusion/incflo_diffusion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ incflo::average_velocity_eta_to_faces (int lev, MultiFab const& cc_eta) const
// (this should be the same for scalar and eta)
EB_interp_CellCentroid_to_FaceCentroid (cc_eta, GetArrOfPtrs(r), 0, 0, 1, geom[lev],
get_tracer_bcrec());
EB_set_covered_faces(GetArrOfPtrs(r), Real(0.0));
// amrex::average_cellcenter_to_face(GetArrOfPtrs(r), cc_eta, Geom(lev));
#else
amrex::average_cellcenter_to_face(GetArrOfPtrs(r), cc_eta, Geom(lev));
Expand All @@ -335,6 +336,7 @@ incflo::average_scalar_eta_to_faces (int lev, int comp, MultiFab const& cc_eta)
#ifdef AMREX_USE_EB
EB_interp_CellCentroid_to_FaceCentroid (cc, GetArrOfPtrs(r), 0, 0, 1, geom[lev],
get_tracer_bcrec());
EB_set_covered_faces(GetArrOfPtrs(r), Real(0.0));
#else
amrex::average_cellcenter_to_face(GetArrOfPtrs(r), cc, Geom(lev));
#endif
Expand Down
Loading