templates/qtproj: use QMAKEVER to select qmake version - #111
Merged
Merged
Conversation
OriginCode
marked this pull request as draft
September 12, 2026 17:10
OriginCode
force-pushed
the
qtproj-refactor
branch
2 times, most recently
from
September 12, 2026 17:22
bd509a6 to
f8c13f2
Compare
Member
Author
|
Tested with When When |
OriginCode
marked this pull request as ready for review
September 12, 2026 17:28
The qtproj template did not allow building with Qt 6's qmake. Remove the unused `QT_SELECT` variable since we no longer ship `qtchooser`. Introduce a new variable `QMAKEVER` to specify the `qmake` version. Require `QMAKEVER` to be set to avoid ambiguity. Signed-off-by: Kaiyang Wu <origincode@aosc.io>
OriginCode
force-pushed
the
qtproj-refactor
branch
from
September 12, 2026 17:29
f8c13f2 to
4c790d6
Compare
MingcongBai
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qtproj template did not allow building with Qt 6's qmake.
Remove the unused
QT_SELECTvariable since we no longer shipqtchooser. Introduce a new variableQMAKEVERto specify theqmakeversion. RequireQMAKEVERto be set to avoid ambiguity.