Valgrind support added for unittests

[AnttiKauppila]

Added an option to select Valgrind to be used for unittests from command line

Summary of changes

Added an option to select Valgrind to be used for unittests from command line
can be used by calling mbed test --unittest --valgrind

Impact of changes

Migration actions required

Documentation

Tool specific help is part of this PR, mbed-cli must be updated also to add same option hint.

---

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-ipcore

[AnttiKauppila]

ARMmbed/mbed-cli#940

[mbed-ci]

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_unittests

[0xc0170]

CI restarted

[mbed-ci]

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 2
Build artifacts

[AnttiKauppila]

@jamesbeyond Please review

[jamesbeyond]

Hi @AnttiKauppila, this is looking good! And I got 2 questions to ask:

1. is this feature for Linux only? also is this will throw a proper message if Valgrind is not installed?
2. currently in the CI Valgrind is running separately: https://github.com/ARMmbed/mbed-os-ci/blob/master/vars/unittests.groovy#L215 , if the improvement is in place, can we use this unittest option to replace that

maybe @VeliMattiLahtela need to aware of the 2nd question aswell

[michalpasztamobica]

@jamesbeyond , regarding question (1), I have good experience running unittests and Valgrind on Linux Subsystem For Windows.

[AnttiKauppila]

@jamesbeyond

1. This is for all systems having "valgrind".
2. Yes, and we should. Just add --valgrind after https://github.com/ARMmbed/mbed-os-ci/blob/master/vars/unittests.groovy#L210
   • Also this has a neat feature of putting valgrind errors into a specific .log file which can then be linked easily in case of any errors!

[AnttiKauppila]

@jamesbeyond Added the handling in case valgrind is missing

[jamesbeyond]

LGTM

[kjbracey]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 3
Build artifacts

[petroborys]

Hi, @AnttiKauppila, how can I use “mbed test” argument --valgrind?

mbed test --unittest --valgrind returned ERROR: Unknown Error: sequence item 3: expected str instance, bool found

@jamesbeyond

1. This is for all systems having "valgrind".

2. Yes, and we should. Just add --valgrind after https://github.com/ARMmbed/mbed-os-ci/blob/master/vars/unittests.groovy#L210

   • Also this has a neat feature of putting valgrind errors into a specific .log file which can then be linked easily in case of any errors!

The link in p.2 is disabled. Unable to find any information about mbed test and valgrind. Thanks!

[kivaisan]

@petroborys mbed-cli has a bug with python 3.x. Fix is available but it is not released yet: ARMmbed/mbed-cli#965