Skip to content

nsapi_dns: Convert to Chrono#12428

Merged
0xc0170 merged 2 commits into
ARMmbed:masterfrom
kjbracey:chrono_dns
May 13, 2020
Merged

nsapi_dns: Convert to Chrono#12428
0xc0170 merged 2 commits into
ARMmbed:masterfrom
kjbracey:chrono_dns

Conversation

@kjbracey

@kjbracey kjbracey commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

Summary of changes

Convert DNS client code to use new APIs from #12425.

Impact of changes

Eliminate use of deprecated APIs

Migration actions required

n/a

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify Bot added the needs: work label Feb 13, 2020
@ciarmcom ciarmcom requested review from a team February 13, 2020 16:00
@ciarmcom

ciarmcom commented Feb 13, 2020

Copy link
Copy Markdown
Member

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

michalpasztamobica
michalpasztamobica reviewed Feb 13, 2020
View reviewed changes
Comment thread features/netsocket/nsapi_dns.cpp
#include "SingletonPtr.h"

using namespace std::chrono;
using rtos::Kernel::Clock;

@michalpasztamobica michalpasztamobica Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? (I mean using rtos::Kernel::Clock;)

@kjbracey kjbracey Feb 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it saves typing rtos::Kernel:: a fair few times in the file. Could just go halfway with the more conventional using namespace rtos.

adbridge
adbridge previously approved these changes Mar 25, 2020
View reviewed changes
@adbridge

adbridge commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

@kjbracey-arm is this PR now dependent on C++ Chrono support #12689 instead ?

@0xc0170 0xc0170 removed the needs: CI label Mar 26, 2020
@mergify mergify Bot dismissed adbridge’s stale review April 30, 2020 10:07

Pull request has been modified.

@kjbracey

kjbracey commented Apr 30, 2020

Copy link
Copy Markdown
Contributor Author

Rebased - no changes needed, but will trigger CI, at least.

@0xc0170

0xc0170 commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

CI started

@mbed-ci

mbed-ci commented Apr 30, 2020

Copy link
Copy Markdown

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170

0xc0170 commented May 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@kjbracey-arm Can you review unittests failures? does this need a rerun?

@kjbracey

kjbracey commented May 11, 2020

Copy link
Copy Markdown
Contributor Author

CI started

@mbed-ci

mbed-ci commented May 11, 2020

Copy link
Copy Markdown

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 5c71ad8 into ARMmbed:master May 13, 2020
@mergify mergify Bot removed the ready for merge label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge left review comments

+1 more reviewer

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-rc1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kjbracey @ciarmcom @adbridge @0xc0170 @mbed-ci @michalpasztamobica