Skip to content

NFC: Convert to Chrono#12432

Merged
0xc0170 merged 1 commit into
ARMmbed:masterfrom
kjbracey:chrono_nfc
May 13, 2020
Merged

NFC: Convert to Chrono#12432
0xc0170 merged 1 commit into
ARMmbed:masterfrom
kjbracey:chrono_nfc

Conversation

@kjbracey

Copy link
Copy Markdown
Contributor

Summary of changes

Convert NFC code to use new APIs from #12425.

Impact of changes

Eliminate use of deprecated APIs

This work originally revealed off-by-1000 error on timing, but that has already been fixed in #12401, so no functional change.

Migration actions required

n/a

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@mergify mergify Bot added the needs: work label Feb 14, 2020
@ciarmcom ciarmcom requested review from a team February 14, 2020 10:00
@ciarmcom

Copy link
Copy Markdown
Member

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

adbridge
adbridge previously approved these changes Mar 25, 2020
@adbridge

Copy link
Copy Markdown
Contributor

@pan- could we have a review please ?

@0xc0170

0xc0170 commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

Replaced by C++ Chrono support #12689

Waiting for this PR to land

@kjbracey

Copy link
Copy Markdown
Contributor Author

Rebased.

@0xc0170

0xc0170 commented May 8, 2020

Copy link
Copy Markdown
Contributor

CI started

@mbed-ci

mbed-ci commented May 8, 2020

Copy link
Copy Markdown

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit b083389 into ARMmbed:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants