Skip to content

feat: implement Dead-Letter Queue (DLQ) infrastructure and management… - #169

Merged
mergekeeper[bot] merged 6 commits into
ASTROIDX556:mainfrom
muhsar27:feat-implement-BullmQ
Aug 31, 2026
Merged

feat: implement Dead-Letter Queue (DLQ) infrastructure and management…#169
mergekeeper[bot] merged 6 commits into
ASTROIDX556:mainfrom
muhsar27:feat-implement-BullmQ

Conversation

@muhsar27

Copy link
Copy Markdown
Contributor

… service

Summary

Implements a dead-letter queue (DLQ) processing and administrative management system for BullMQ jobs across background workers (transaction execution, webhook delivery, risk analysis, and notifications) with secured RBAC-guarded administrative endpoints to inspect, retry, and purge failed jobs.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation
  • CI / tooling

Related issue

Closes #98

Why this change is needed

When background workers exhaust maximum retry attempts on transient or permanent failures (such as third-party API outages, invalid payloads, or network timeouts), jobs should be routed to a designated Dead-Letter Queue structure for forensic debugging, audit ledgering, and administrative remediation. Without dedicated DLQ tooling, failed jobs remain opaque or require manual database/Redis interventions. This feature provides a centralized DlqProcessor and a secured DlqController allowing administrators to inspect full error payloads/stack traces, retry failed jobs individually or in bulk, and purge obsolete records under strict OWNER / ADMIN role access control.

Checklist

  • npm run build passes
  • npm test passes
  • npm run lint passes
  • npm run typecheck passes
  • No secrets added to tracked files
  • PR description explains the why, not just the what

@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@muhsar27 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Aug 30, 2026

Copy link
Copy Markdown

MergeKeeper review

Scope: in scope for linked issue #98.
Verdict: clean

The pull request correctly implements the BullMQ dead-letter queue processor, administrative DLQ endpoints, associated DTOs, and unit tests as required by issue #98.

Reviewed commit: aad03352c8fa17936c4cf5c1ad91da2829f9ab40.
CI and merge eligibility are checked separately.

@mergekeeper

mergekeeper Bot commented Aug 30, 2026

Copy link
Copy Markdown

MergeKeeper review unavailable

AI provider review response did not contain valid JSON

No approval or merge action was taken.

@mergekeeper

mergekeeper Bot commented Aug 30, 2026

Copy link
Copy Markdown

MergeKeeper merge status

Status: blocked
PR state: open
Mergeability: mergeable
Checked commit: 8c9c9ec58f84a63609483ce0c40058007c8671a0.

Reason:
GitHub pull request merge request failed with 405: 4 of 4 required status checks are expected.

Next steps:
This required status check is enforced directly by the repository's branch rules, independent of MergeKeeper's own CI evaluation — a maintainer merge override cannot bypass it unless MergeKeeper is authorized to.

  1. Wait for the check to pass, or fix the underlying failure.
  2. To let an explicit override bypass this check going forward, add the MergeKeeper GitHub App as a Bypass actor on the ruleset (Settings → Rules → Rulesets → the ruleset → Bypass list).

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Successfully implemented the BullMQ dead-letter queue processor, administrative DLQ management service, and RBAC-secured endpoints with complete unit test coverage.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

The pull request correctly implements the BullMQ dead-letter queue processor, administrative DLQ endpoints, associated DTOs, and unit tests as required by issue #98.

@mergekeeper
mergekeeper Bot merged commit daa8e19 into ASTROIDX556:main Aug 31, 2026
4 checks passed
@mergekeeper

mergekeeper Bot commented Aug 31, 2026

Copy link
Copy Markdown

Merged

Merged with squash.

@muhsar27
muhsar27 deleted the feat-implement-BullmQ branch August 31, 2026 00:50
lewistemple22 pushed a commit to lewistemple22/astroid-api that referenced this pull request Aug 31, 2026
ASTROIDX556#169)

* feat: implement Dead-Letter Queue (DLQ) infrastructure and management service

* refactor: simplify nest script commands by removing local node_modules path references

* feat: implement root application module and define queue constants for background processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement BullMQ dead-letter queue processor and administrative retry management endpoints

1 participant