feat(stellar): implement Soroban contract event ingestion parser - #42
feat(stellar): implement Soroban contract event ingestion parser #42samkay1277 wants to merge 18 commits into
Conversation
This commit removes the SorobanEventParserService and its related interfaces and constants, effectively deleting the event parsing functionality for Soroban events.
|
@samkay1277 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
privyy-bit
left a comment
privyy-bit
left a comment
There was a problem hiding this comment.
Approved after automated review verification.
|
Needs changes StellarTransactionService was accidentally removed from StellarModule providers and exports during SorobanEventParserService registration.
Reviewed commit: |
![mergekeeper[bot]](https://avatars.githubusercontent.com/u/173216192?s=60&v=4){kind=small}
There was a problem hiding this comment.
Needs changes
Duplicate nested service file created under src/src/modules/stellar/services/soroban-event-parser.service.ts.
src/src/modules/stellar/services/soroban-event-parser.service.ts:1: Remove duplicate or misnested service file under src/src/.
Reviewed commit: fb55db2b8b2da3d4b309893a7e7d6f701a251880.
privyy-bit
left a comment
privyy-bit
left a comment
There was a problem hiding this comment.
Approved after automated review verification.
Superseded: requested changes were addressed; re-validated before merge.
privyy-bit
left a comment
privyy-bit
left a comment
There was a problem hiding this comment.
Approved after automated review verification.
CI Checks Failed — Action NeededThe continuous integration checks on this pull request are failing. The maintainer cannot merge until all required checks pass. Failing checks:
What to do: review the failing checks in the "Checks" tab above, fix the issues in your code, and push the changes. You can also click the Resolve button to let the automation attempt the fix. Sent automatically on behalf of the maintainer. |
There was a problem hiding this comment.
Needs changes
Duplicate nested file created at src/src/modules/stellar/services/soroban-event-parser.service.ts due to incorrect path nesting.
src/src/modules/stellar/services/soroban-event-parser.service.ts:1: Remove this duplicate nested directory path (src/src/...) and keep only the correct file under src/modules/stellar/services/soroban-event-parser.service.ts
Reviewed commit: e0c9a18d9e2b1632b4f75445beae7798ec579069.
|
@privyy-bit I have done the review on the failing check and I have corrected |
There was a problem hiding this comment.
Needs changes
A duplicate nested path file was introduced in error and needs to be removed.
src/src/modules/stellar/services/soroban-event-parser.service.ts:1: Remove duplicate nested file created at incorrect path src/src/modules/stellar/services/soroban-event-parser.service.ts.
Reviewed commit: f2b04e58dad95e038ca26a211d7f0ea868486672.
There was a problem hiding this comment.
Needs changes
An empty duplicate service file was accidentally committed under an incorrect nested directory path.
src/src/modules/stellar/services/soroban-event-parser.service.ts:1: Remove this duplicate empty file created under the incorrect nested directory path src/src/modules/stellar/services/.
Reviewed commit: 49bf0d8c8691886eb3d75cc2b71954fb9dcd8bc1.
There was a problem hiding this comment.
Needs changes
A duplicate nested file src/src/modules/stellar/services/soroban-event-parser.service.ts was accidentally added and needs to be removed.
src/src/modules/stellar/services/soroban-event-parser.service.ts:1: Remove duplicate nested directory structure and redundant empty file.
Reviewed commit: b9dcd1946bcff8ac3e5a04329b4ceef6dabac79a.
There was a problem hiding this comment.
Needs changes
The StellarModule accidentally removes StellarTransactionService while registering SorobanEventParserService.
src/modules/stellar/stellar.module.ts:11: StellarTransactionService was removed from providers and exports in StellarModule. This looks like an accidental regression and should be preserved alongside SorobanEventParserService.
Reviewed commit: 018ae282c388bc1b176634b2ed3f34795bcf0e95.
There was a problem hiding this comment.
Needs changes
A typo in log string formatting prevents correct error interpolation and a required service was removed from StellarModule exports.
src/modules/stellar/services/soroban-event-parser.service.ts:153: Malformed template string syntax '( {raw.contractId ?? '?'} tx= ){raw.contractId ?? '?'}' instead of template variables${...}.src/modules/stellar/stellar.module.ts:33: StellarTransactionService was removed from module providers and exports, which may break dependent modules expecting it.
Reviewed commit: af7d898be34cc49c22ac0b8011b9c04795124c9e.
There was a problem hiding this comment.
Needs changes
There is a syntax error in soroban-event-parser.service.ts on line 144 due to a malformed template literal interpolation and an extra closing brace at the end of the file.
src/modules/stellar/services/soroban-event-parser.service.ts:144: Syntax error in template literal string interpolation: '( {raw.contractId ?? '?'} tx= ){raw.txHash ?? '?'}' contains unmatched backslashes and braces.src/modules/stellar/services/soroban-event-parser.service.ts:332: Unexpected extra closing brace at the end of the file causing a compilation error.
Reviewed commit: 18cc4a9a83dc4677e5971b0eaa03f0545c723300.
|
MergeKeeper review Scope: in scope for linked issue The pull request correctly implements the Soroban contract event ingestion pipeline parser, registers it in the StellarModule, and provides comprehensive unit tests using Vitest. Reviewed commit: |
There was a problem hiding this comment.
Needs changes
StellarTransactionService was accidentally removed from StellarModule providers and exports during SorobanEventParserService registration.
src/modules/stellar/stellar.module.ts:11: StellarTransactionService was removed from imports/providers/exports in StellarModule, which might break existing transaction service consumers.
Reviewed commit: 0ec75aa995e615b92239794778311e8d09438dee.
|
MergeKeeper review unavailable AI provider review response did not contain valid JSON No approval or merge action was taken. |
3 participants
Summary
Implements a Soroban event ingestion parser that decodes raw Stellar RPC event XDR (topics + value), maps known SAC-style patterns into typed payloads, and emits NestJS domain events for downstream modules (budgets, audits, transactions).
Changes
SorobanEventParserService(src/modules/stellar/services/soroban-event-parser.service.ts)@stellar/stellar-sdk(xdr+scValToNative)transfer,mint,burn,approvestellar.soroban_event_parsedandtransaction.confirmedon successful transfer mappingStellarModulesoroban-event-parser.service.spec.ts(realistic mocks +EventEmitter2spies)Acceptance criteria
EventEmitter2Closes #28