test(client): add comprehensive retry logic tests for issue #144 - #171
Merged
Conversation
…56#144 Expand the retry test suite from 6 to 16 tests to fully satisfy the acceptance criteria for exponential backoff with Retry-After support. New tests verify: - Retry-After header is respected on 429 responses (waits the specified duration before retrying) - Non-retriable errors (400, 401, 404) are never retried and propagate the correct typed error (ValidationError, AuthenticationError, NotFoundError) - Non-idempotent methods (POST) are not retried by default - Idempotent methods (PUT) are retried as expected - retry: false completely disables the retry mechanism - Exponential backoff with increasing delays between retry attempts - 429 rate limit errors trigger retries 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@entitydev30 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
MergeKeeper review Scope: in scope for linked issue Comprehensive unit tests are added for retry logic, exponential backoff, Retry-After headers, and non-retriable error behaviors in the client package. Reviewed commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the retry test suite from 6 to 16 tests to fully satisfy the acceptance criteria for exponential backoff with Retry-After support. New tests verify:
🤖 Generated with Codebuff
Summary
Type of change
Related issue
Closes #144
Checklist
npm run buildpassesnpm run typecheckpassesnpm run lintpasses