feat(types): add Zod runtime validation schemas for core resource DTOs - #173
Merged
Merged
Conversation
Implements issue ASTROIDX556#146: Zod validation schemas for core domain models and DTOs in @astroid/types, enabling robust runtime validation at SDK boundaries. Changes: - Added Zod as a dependency to @astroid/types - Created packages/types/src/schemas.ts with: - Enum schemas for all platform enumerations (AgentRole, WalletType, PolicyType, TransactionStatus, etc.) - Entity schemas for core domain models (Agent, Wallet, Policy, Budget, Transaction, Proposal, Approval, Notification, etc.) - DTO input schemas for create/update operations - Generic validate() and validateOrThrow() helpers - Convenience validators: validateAgent, validateWallet, validatePolicy, validateBudget, validateTransaction, and DTO input validators - Exported all schemas and helpers from @astroid/types entry point - Added 39 comprehensive tests covering: - Valid payload acceptance for all entity schemas - Invalid payload rejection with descriptive error messages - Missing required field detection - Invalid enum value detection - DTO input schema validation - Validation helper functions (validate, validateOrThrow, convenience) - Type compatibility verification with TypeScript interfaces 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@entitydev30 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
MergeKeeper review Scope: in scope for linked issue Successfully added Zod runtime validation schemas, helper functions, exports, and tests for core resource DTOs in @astroid/types. Reviewed commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements issue #146: Zod validation schemas for core domain models and DTOs in @astroid/types, enabling robust runtime validation at SDK boundaries.
Changes:
🤖 Generated with Codebuff
Summary
Type of change
Related issue
Closes #146
Checklist
npm run buildpassesnpm run typecheckpassesnpm run lintpasses