Skip to content

feat: build department budget allocation breakdown chart and table component - #100

Merged
mergekeeper[bot] merged 4 commits into
ASTROIDX556:mainfrom
temisan0x:feat/69-department-budget-breakdown
Sep 1, 2026
Merged

feat: build department budget allocation breakdown chart and table component#100
mergekeeper[bot] merged 4 commits into
ASTROIDX556:mainfrom
temisan0x:feat/69-department-budget-breakdown

Conversation

@temisan0x

@temisan0x temisan0x commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Implements DepartmentBudgetBreakdown with Recharts donut/bar chart and TanStack Table showing allocated/spent/remaining per department.

  • Recharts donut/bar chart for budget allocation across departments
  • TanStack Table with sortable columns
  • Tooltips showing accurate numeric values and currency formatting
  • Respects dark/light theme tokens in src/styles/tokens.css
  • Responsive container, resizes correctly

Type of change

  • New feature

Checklist

  • Strict TypeScript type checking passes
  • npm run typecheck && npm run lint

Closes #69

Show engineering, marketing, and operations envelopes as a theme-aware donut plus a sortable allocated/spent/remaining table.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@temisan0x is attempting to deploy a commit to the Cjay's projects Team on Vercel.

A member of the Team first needs to authorize it.

@mergekeeper

mergekeeper Bot commented Aug 31, 2026

Copy link
Copy Markdown

Needs review

Linked to #80, but the diff does not match the issue scope.

The pull request implements budget breakdown features instead of the required Stellar wallet transaction history table with export and filter controls.

Reviewed commit: 3b294fa53243c690209aa6bef45c5c2d529cee59.

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@temisan0x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Aug 31, 2026

Copy link
Copy Markdown

MergeKeeper review

Scope: in scope for linked issue #69.
Verdict: clean

The department budget allocation component, types, and page integrations have been correctly implemented using Recharts and TanStack Table according to all acceptance criteria and repository patterns.

Reviewed commit: b23530d46de0514ead928ae0a3380d41664be129.
CI and merge eligibility are checked separately.

@mergekeeper

mergekeeper Bot commented Aug 31, 2026

Copy link
Copy Markdown

MergeKeeper merge status

Status: blocked
PR state: open
Mergeability: mergeable
Checked commit: 67897fd5fb67ac6bc695a36dcbc4eda80e209528.

Reason:
GitHub pull request merge request failed with 405: 3 of 3 required status checks have not succeeded: 2 expected.

Next steps:
This required status check is enforced directly by the repository's branch rules, independent of MergeKeeper's own CI evaluation — a maintainer merge override cannot bypass it unless MergeKeeper is authorized to.

  1. Wait for the check to pass, or fix the underlying failure.
  2. To let an explicit override bypass this check going forward, add the MergeKeeper GitHub App as a Bypass actor on the ruleset (Settings → Rules → Rulesets → the ruleset → Bypass list).

@temisan0x temisan0x changed the title Add sortable transaction history table with filters and export feat: build department budget allocation breakdown chart and table component Aug 31, 2026
…budget-breakdown

# Conflicts:
#	src/app/(dashboard)/budgets/page.tsx
#	src/features/budgets/BudgetBreakdownChart.tsx
#	src/features/budgets/types.ts

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

The pull request correctly implements the DepartmentBudgetBreakdown component, types, and integrations fulfilling all requirements.

…budget-breakdown

# Conflicts:
#	src/features/budgets/index.ts
#	src/types/index.ts

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

The department budget allocation component, types, and page integrations have been correctly implemented using Recharts and TanStack Table according to all acceptance criteria and repository patterns.

@mergekeeper
mergekeeper Bot merged commit 5ddaa59 into ASTROIDX556:main Sep 1, 2026
3 of 4 checks passed
@mergekeeper

mergekeeper Bot commented Sep 1, 2026

Copy link
Copy Markdown

Merged

Merged with squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: build department budget allocation breakdown chart and table component

1 participant