Skip to content

feat(governance): implement multi-sig signer management and threshold view (#59) - #96

Merged
Cjay-Cyber-2 merged 13 commits into
ASTROIDX556:mainfrom
Victorakinwunmi:feat/signer-management-view
Sep 1, 2026
Merged

feat(governance): implement multi-sig signer management and threshold view (#59)#96
Cjay-Cyber-2 merged 13 commits into
ASTROIDX556:mainfrom
Victorakinwunmi:feat/signer-management-view

Conversation

@Victorakinwunmi

Copy link
Copy Markdown

Closes #59

Summary of Changes

  • Created src/features/governance/components/SignerManagementView.tsx providing a multi-sig signer management interface.
  • Added client-side validation for Stellar public keys (G..., 56 base32 characters).
  • Implemented signer addition, removal, and custom weight assignment.
  • Implemented low, medium, and high threshold configuration controls.
  • Added type definitions in src/types/governance.ts (Signer, ThresholdConfig) and re-exported in src/types/index.ts.
  • Structured with responsive Tailwind CSS layouts and Lucide React icons.

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@Victorakinwunmi is attempting to deploy a commit to the Cjay's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@Victorakinwunmi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Aug 31, 2026

Copy link
Copy Markdown

MergeKeeper review

Scope: in scope for linked issue #59.
Verdict: clean

Successfully implemented multi-sig signer management and threshold configuration view along with required types and supporting components.

Reviewed commit: a2885529c2a827ae307dd01020e256ca29ac62d2.
CI and merge eligibility are checked separately.

@mergekeeper

mergekeeper Bot commented Aug 31, 2026

Copy link
Copy Markdown

MergeKeeper merge status

Status: blocked
PR state: open
Mergeability: mergeable
Checked commit: a2885529c2a827ae307dd01020e256ca29ac62d2.

Reason: One or more required CI checks failed.

Failing checks:

Next steps:

  1. Open the failing check details above and fix the reported error.
  2. Run the same checks locally where possible.
  3. Commit and push the fix.
  4. MergeKeeper will automatically re-review the updated PR.

@mergekeeper

mergekeeper Bot commented Aug 31, 2026

Copy link
Copy Markdown

Needs changes

The PR introduces unrelated modifications to the transactions page and removes existing table column definitions and components.

Reviewed commit: e460ee0203a299664e06a7a782e875f287fd608a.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

The PR introduces unrelated changes in transactions/page.tsx that are outside the scope of issue #59.

  • src/app/(dashboard)/transactions/page.tsx:13: Unrelated modification introducing Badge and RiskBadge components in the transactions page, which is out of scope for issue #59.

Reviewed commit: da3aa15da8920a91115e06441a78d771cae66d89.

@mergekeeper

mergekeeper Bot commented Aug 31, 2026

Copy link
Copy Markdown

Needs review

Linked to #59, but the diff does not match the issue scope.

The pull request includes extensive refactoring and unrelated modifications to transactions page and types index which are out of scope for issue #59.

Reviewed commit: b0be7de214f6ab8b47e2779003d16ebaf70ea4d0.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

The PR introduces unrelated modifications to the transactions page and removes existing table column definitions and components.

  • src/app/(dashboard)/transactions/page.tsx:1: Significant refactoring and removal of transaction table columns and query logic in the transactions page is out of scope for issue #59.

Reviewed commit: e460ee0203a299664e06a7a782e875f287fd608a.

@Cjay-Cyber-2
Cjay-Cyber-2 merged commit 3eaef46 into ASTROIDX556:main Sep 1, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: implement multi-sig signer management and threshold configuration view

2 participants