feat(governance): implement multi-sig signer management and threshold view (#59) - #96
Conversation
|
@Victorakinwunmi is attempting to deploy a commit to the Cjay's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Victorakinwunmi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
MergeKeeper review Scope: in scope for linked issue Successfully implemented multi-sig signer management and threshold configuration view along with required types and supporting components. Reviewed commit: |
|
MergeKeeper merge status Status: blocked Reason: One or more required CI checks failed. Failing checks:
Next steps:
|
|
Needs changes The PR introduces unrelated modifications to the transactions page and removes existing table column definitions and components.
Reviewed commit: |
There was a problem hiding this comment.
Needs changes
The PR introduces unrelated changes in transactions/page.tsx that are outside the scope of issue #59.
src/app/(dashboard)/transactions/page.tsx:13: Unrelated modification introducing Badge and RiskBadge components in the transactions page, which is out of scope for issue #59.
Reviewed commit: da3aa15da8920a91115e06441a78d771cae66d89.
|
Needs review Linked to The pull request includes extensive refactoring and unrelated modifications to transactions page and types index which are out of scope for issue #59. Reviewed commit: |
There was a problem hiding this comment.
Needs changes
The PR introduces unrelated modifications to the transactions page and removes existing table column definitions and components.
src/app/(dashboard)/transactions/page.tsx:1: Significant refactoring and removal of transaction table columns and query logic in the transactions page is out of scope for issue #59.
Reviewed commit: e460ee0203a299664e06a7a782e875f287fd608a.
Closes #59
Summary of Changes
src/features/governance/components/SignerManagementView.tsxproviding a multi-sig signer management interface.G..., 56 base32 characters).src/types/governance.ts(Signer,ThresholdConfig) and re-exported insrc/types/index.ts.