feat: self-contained Ctrl+Q/I/U item-lookup shortcuts

av_tools/api/item_lookups.py

@@ -0,0 +1,291 @@
+
+
+from __future__ import annotations
+
+import json
+from typing import Any
+
+import frappe
+from frappe import _
+from frappe.utils import cint, flt
+
+DEFAULT_MAX_RECORDS = 20
+
+
+def _get_stock_ledger_entries(item_code: str) -> list[dict]:
+	return frappe.db.sql(
+		"""
+		SELECT sle.batch_no, sle.item_code, sle.warehouse,
+		       sle.qty_after_transaction AS actual_qty
+		FROM `tabStock Ledger Entry` sle
+		INNER JOIN (
+			SELECT IF(batch_no IS NULL, '', batch_no) AS batch_no,
+			       item_code, warehouse,
+			       MAX(posting_datetime) AS posting_datetime
+			FROM `tabStock Ledger Entry`
+			GROUP BY IF(batch_no IS NULL, '', batch_no), item_code, warehouse
+		) AS sle_max
+			ON IF(sle.batch_no IS NULL, '', sle.batch_no) = sle_max.batch_no
+			AND sle.item_code = sle_max.item_code
+			AND sle.warehouse = sle_max.warehouse
+			AND sle.posting_datetime = sle_max.posting_datetime
+		WHERE sle.docstatus = 1
+		  AND sle.is_cancelled = 0
+		  AND sle.item_code = %(item_code)s
+		ORDER BY sle.warehouse, sle.item_code, sle.batch_no
+		""",
+		{"item_code": item_code},
+		as_dict=1,
+	)
+
+
+@frappe.whitelist()
+def get_item_info(item_code: Any):
+	"""Return per-(warehouse, batch) on-hand balance for an item, with batch expiry data."""
+	sle = _get_stock_ledger_entries(item_code)
+	iwb_map: dict = {}
+	float_precision = cint(frappe.db.get_default("float_precision")) or 3
+
+	for d in sle:
+		iwb_map.setdefault(d.item_code, {}).setdefault(d.warehouse, {}).setdefault(
+			d.batch_no, frappe._dict({"bal_qty": 0.0})
+		)
+		qty_dict = iwb_map[d.item_code][d.warehouse][d.batch_no]
+
+		expiry_date = frappe.db.get_value("Batch", d.batch_no, "expiry_date") if d.batch_no else None
+		if expiry_date:
+			exp_date = frappe.utils.data.getdate(expiry_date)
+			qty_dict.expires_on = exp_date
+			expires_in_days = (exp_date - frappe.utils.datetime.date.today()).days
+			qty_dict.expiry_status = expires_in_days if expires_in_days > 0 else 0
+
+		qty_dict.actual_qty = flt(qty_dict.actual_qty, float_precision) + flt(
+			d.actual_qty, float_precision
+		)
+
+	result = []
+	for item_code_key, warehouses in iwb_map.items():
+		for warehouse, batches in warehouses.items():
+			for batch_no, qty_dict in batches.items():
+				row = {"item_code": item_code_key, "warehouse": warehouse, "batch_no": batch_no}
+				row.update(qty_dict)
+				result.append(row)
+	return result
+
+
+def _collect_prices(rows: list[dict], rate_field: str, mapper, max_records: int) -> list[dict]:
+	prices: list[dict] = []
+	for row in rows:
+		if row.get(rate_field) and len(prices) <= max_records:
+			prices.append(mapper(row))
+	return prices
+
+
+@frappe.whitelist()
+def get_item_prices(item_code: Any, currency: Any, customer: Any = None, company: Any = None):
+	"""Sales Invoice historical prices for an item (legacy shape: `price`, `date`)."""
+	conditions = ""
+	params: dict = {"item_code": item_code, "currency": currency, "company": company}
+	if customer:
+		conditions = " AND SI.customer = %(customer)s"
+		params["customer"] = customer
+
+	rows = frappe.db.sql(
+		f"""
+		SELECT SI.name, SI.posting_date, SI.customer, SIT.item_code, SIT.qty, SIT.rate
+		FROM `tabSales Invoice` AS SI
+		INNER JOIN `tabSales Invoice Item` AS SIT ON SIT.parent = SI.name
+		WHERE SIT.item_code = %(item_code)s
+		  AND SI.docstatus = 1
+		  AND SI.currency = %(currency)s
+		  AND SI.is_return != 1
+		  AND SI.company = %(company)s
+		  {conditions}
+		ORDER BY SI.posting_date DESC
+		""",
+		params,
+		as_dict=True,
+	)
+
+	return _collect_prices(
+		rows,
+		"rate",
+		lambda r: {
+			"name": r.item_code,
+			"item_code": r.item_code,
+			"price": r.rate,
+			"date": r.posting_date,
+			"invoice": r.name,
+			"customer": r.customer,
+			"qty": r.qty,
+		},
+		DEFAULT_MAX_RECORDS,
+	)
+
+
+@frappe.whitelist()
+def get_item_prices_custom(filters: Any = None, start: Any = 0, limit: Any = 20):
+	"""Sales Invoice historical prices for an item (Ctrl+I shape: `rate`, `posting_date`)."""
+	if isinstance(filters, str):
+		try:
+			filters = json.loads(filters)
+		except json.JSONDecodeError:
+			frappe.throw(_("Invalid format for filters. Ensure it's a valid JSON object."))
+	filters = filters or {}
+
+	customer = filters.get("customer", "")
+	company = filters.get("company", "")
+	item_code = filters.get("item_code", "")
+	currency = filters.get("currency", "")
+	posting_date_range = filters.get("posting_date")
+	max_records = int(start) + int(limit)
+
+	conditions = ""
+	params: dict = {"item_code": item_code, "currency": currency, "company": company}
+	if posting_date_range and isinstance(posting_date_range, (list, tuple)) and len(posting_date_range) > 1:
+		try:
+			conditions += " AND DATE(SI.posting_date) BETWEEN %(from_date)s AND %(to_date)s"
+			params["from_date"] = posting_date_range[1][0]
+			params["to_date"] = posting_date_range[1][1]
+		except (IndexError, TypeError):
+			pass
+	if customer:
+		conditions += " AND SI.customer = %(customer)s"
+		params["customer"] = customer
+
+	rows = frappe.db.sql(
+		f"""
+		SELECT SI.name, SI.posting_date, SI.customer, SIT.item_code, SIT.qty, SIT.rate
+		FROM `tabSales Invoice` AS SI
+		INNER JOIN `tabSales Invoice Item` AS SIT ON SIT.parent = SI.name
+		WHERE SIT.item_code = %(item_code)s
+		  AND SI.docstatus = 1
+		  AND SI.currency = %(currency)s
+		  AND SI.is_return != 1
+		  AND SI.company = %(company)s
+		  {conditions}
+		ORDER BY SI.posting_date DESC
+		""",
+		params,
+		as_dict=True,
+	)
+
+	return _collect_prices(
+		rows,
+		"rate",
+		lambda r: {
+			"name": r.item_code,
+			"item_code": r.item_code,
+			"rate": r.rate,
+			"posting_date": r.posting_date,
+			"invoice": r.name,
+			"customer": r.customer,
+			"qty": r.qty,
+		},
+		max_records,
+	)
+
+
+@frappe.whitelist()
+def get_item_prices_custom_po(filters: Any = None, start: Any = 0, limit: Any = 20):
+	"""Purchase Invoice historical prices for an item (Ctrl+I on PO shape)."""
+	if isinstance(filters, str):
+		try:
+			filters = json.loads(filters)
+		except json.JSONDecodeError:
+			frappe.throw(_("Invalid format for filters. Ensure it's a valid JSON object."))
+	filters = filters or {}
+
+	supplier = filters.get("customer", "")
+	company = filters.get("company", "")
+	item_code = filters.get("item_code", "")
+	currency = filters.get("currency", "")
+	posting_date_range = filters.get("posting_date")
+	max_records = int(start) + int(limit)
+
+	conditions = ""
+	params: dict = {"item_code": item_code, "currency": currency, "company": company}
+	if posting_date_range and isinstance(posting_date_range, (list, tuple)) and len(posting_date_range) > 1:
+		try:
+			conditions += " AND DATE(PI.posting_date) BETWEEN %(from_date)s AND %(to_date)s"
+			params["from_date"] = posting_date_range[1][0]
+			params["to_date"] = posting_date_range[1][1]
+		except (IndexError, TypeError):
+			pass
+	if supplier:
+		conditions += " AND PI.supplier = %(supplier)s"
+		params["supplier"] = supplier
+
+	rows = frappe.db.sql(
+		f"""
+		SELECT PI.name, PI.posting_date, PI.supplier, PIT.item_code, PIT.qty, PIT.rate
+		FROM `tabPurchase Invoice` AS PI
+		INNER JOIN `tabPurchase Invoice Item` AS PIT ON PIT.parent = PI.name
+		WHERE PIT.item_code = %(item_code)s
+		  AND PI.docstatus = 1
+		  AND PI.currency = %(currency)s
+		  AND PI.is_return != 1
+		  AND PI.company = %(company)s
+		  {conditions}
+		ORDER BY PI.posting_date DESC
+		""",
+		params,
+		as_dict=True,
+	)
+
+	return _collect_prices(
+		rows,
+		"rate",
+		lambda r: {
+			"name": r.item_code,
+			"item_code": r.item_code,
+			"rate": r.rate,
+			"posting_date": r.posting_date,
+			"invoice": r.name,
+			"customer": r.supplier,
+			"qty": r.qty,
+		},
+		max_records,
+	)
+
+
+@frappe.whitelist()
+def get_item_prices_po(item_code: Any, currency: Any, customer: Any = None, company: Any = None):
+	"""Purchase Invoice historical prices (legacy PO shape: `price`, `date`)."""
+	conditions = ""
+	params: dict = {"item_code": item_code, "currency": currency, "company": company}
+	if customer:
+		conditions = " AND PI.supplier = %(supplier)s"
+		params["supplier"] = customer
+
+	rows = frappe.db.sql(
+		f"""
+		SELECT PI.name, PI.posting_date, PI.supplier, PIT.item_code, PIT.qty, PIT.rate
+		FROM `tabPurchase Invoice` AS PI
+		INNER JOIN `tabPurchase Invoice Item` AS PIT ON PIT.parent = PI.name
+		WHERE PIT.item_code = %(item_code)s
+		  AND PI.docstatus = 1
+		  AND PI.currency = %(currency)s
+		  AND PI.is_return != 1
+		  AND PI.company = %(company)s
+		  {conditions}
+		ORDER BY PI.posting_date DESC
+		""",
+		params,
+		as_dict=True,
+	)
+
+	return _collect_prices(
+		rows,
+		"rate",
+		lambda r: {
+			"name": r.item_code,
+			"item_code": r.item_code,
+			"price": r.rate,
+			"date": r.posting_date,
+			"invoice": r.name,
+			"customer": r.supplier,
+			"qty": r.qty,
+		},
+		DEFAULT_MAX_RECORDS,
+	)

av_tools/av_tools/delivery_note.js

@@ -6,7 +6,7 @@ frappe.ui.keys.add_shortcut({
 		const current_doc = $(".data-row.editable-row").parent().attr("data-name");
 		const item_row = locals["Delivery Note Item"][current_doc];
 		frappe.call({
-			method: "csf_tz.custom_api.get_item_info",
+			method: "av_tools.api.item_lookups.get_item_info",
 			args: { item_code: item_row.item_code },
 			callback: function (r) {
 				if (r.message.length > 0) {

av_tools/av_tools/stock_entry.js

@@ -8,7 +8,7 @@ frappe.ui.keys.add_shortcut({
 		const current_doc = $(".data-row.editable-row").parent().attr("data-name");
 		const item_row = locals["Stock Entry Detail"][current_doc];
 		frappe.call({
-			method: "csf_tz.custom_api.get_item_info",
+			method: "av_tools.api.item_lookups.get_item_info",
 			args: { item_code: item_row.item_code },
 			callback: function (r) {
 				if (r.message.length > 0) {

av_tools/public/js/po_shortcuts.js

@@ -13,7 +13,7 @@ function ctrlI(TableName) {
 
     // Call the custom API to fetch data
     frappe.call({
-        method: "csf_tz.custom_api.get_item_prices_custom_po",
+        method: "av_tools.api.item_lookups.get_item_prices_custom_po",
         args: { filters: filters },
         callback: function (response) {
             if (response.message && response.message.length > 0) {
@@ -95,7 +95,7 @@ function ctrlU (TableName) {
     const current_doc = $('.data-row.editable-row').parent().attr("data-name");
     const item_row = locals[TableName][current_doc];
     frappe.call({
-        method: 'csf_tz.custom_api.get_item_prices_po',
+        method: 'av_tools.api.item_lookups.get_item_prices_po',
         args: {
             item_code: item_row.item_code,
             currency: cur_frm.doc.currency,

av_tools/public/js/shortcuts.js

@@ -1,10 +1,10 @@
 // Item lookup shortcuts (moved from csf_tz to av_tools)
-// API methods still live in csf_tz.custom_api — both apps must be installed.
+// Backing APIs live in av_tools.api.item_lookups — no csf_tz dependency.
 function ctrlQ (TableName) {
     const current_doc = $('.data-row.editable-row').parent().attr("data-name");
     const item_row = locals[TableName][current_doc];
     frappe.call({
-        method: 'csf_tz.custom_api.get_item_info',
+        method: 'av_tools.api.item_lookups.get_item_info',
         args: { item_code: item_row.item_code },
         callback: function (r) {
             if (r.message.length > 0) {
@@ -100,7 +100,7 @@ function ctrlI(TableName) {
 
     // Call the custom API to fetch data
     frappe.call({
-        method: "csf_tz.custom_api.get_item_prices_custom",
+        method: "av_tools.api.item_lookups.get_item_prices_custom",
         args: { filters: filters },
         callback: function (response) {
             if (response.message && response.message.length > 0) {
@@ -169,7 +169,7 @@ function ctrlU (TableName) {
     const current_doc = $('.data-row.editable-row').parent().attr("data-name");
     const item_row = locals[TableName][current_doc];
     frappe.call({
-        method: 'csf_tz.custom_api.get_item_prices',
+        method: 'av_tools.api.item_lookups.get_item_prices',
         args: {
             item_code: item_row.item_code,
             currency: cur_frm.doc.currency,