Fix/negativevalue v16#348
Closed
iphenelist wants to merge 13 commits into
Closed
Conversation
…hotfix-with-changes Version 16 hotfix with changes
- Update DocType JSONs across modules (vfd, kcb, stanbic, foreign import, insurance, biometric/meal_count, sales & marketing, purchase & stock, TRA/EFD, etc.) for v16 schema - Adjust controllers, reports, hooks, and overrides to v16 Frappe APIs (salary_slip, payroll, landed_cost_voucher, items_revaluation, custom_api, bank_api, selcom, sftp, trade_in, etc.) - Refresh client scripts (payment_entry, payroll_entry, purchase_invoice, sales_invoice); drop obsolete landed_cost_voucher.js - Add v16 cleanup patches: cleanup_invalid_v16_custom_field_links and remove_stale_authotp_custom_fields; update patches.txt - Remove deprecated monkey patch db_transaction_writes and remove_core_doctype_custom_docperm patch - Update pyproject.toml and hooks.py for v16 compatibility
Resolution summary: - 178 delete/modify conflicts: kept deletions (doctypes removed during v16 migration) - 14 trivial JSON conflicts (whitespace only): took ours - 2 foreign_import JSON conflicts (formatting only): took ours - bank_api.py: took theirs (after_insert path needs db.set_value to persist token) - items_revaluation.py, payroll.py: took ours (v16-idiomatic frappe.qb refactors) - tz_insurance_cover_note.py, vehicle_fine_record.py: took ours (blank-line only) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
chore(csf_tz): migrate app to Frappe/ERPNext version-16
…actions ci(csf_tz): fix CI workflow and improve install behavior
- Remove the Trade In feature in full (trade_in package + custom-fields patch deleted; refs cleaned from hooks, custom_api, sales_invoice.js, modules.txt, patches.txt, CSF TZ Settings) - Add tag-and-promote-from-pr-label.yml (parity with propms — tags from csf_tz/__init__.py and promotes to version-15/16/production) - Clear all 91 pre-existing semgrep findings in custom_api.py: Any type hints, frappe.db.get_single_value for CSF TZ Settings, wrap user-facing strings with _(), .format outside _(), drop dict() around frappe.get_doc, nosemgrep on 3 intentional dynamic SQL sites - csf_tz_settings.py: translatable strings, db_set for state writes, commits in background-job paths, drop bare except, fix f-string with no placeholders - Sweep pre-existing bugs in custom_api.py: drop unused msg/space locals, remove duplicate "condition" and "abbr" dict keys - setup_data: Standard (18%) Sales + Purchase tax templates seed with rate=18 and is_default=1 — applies real VAT on fresh installs and auto-fills on new invoices
…ove-trade-in-and-ci-parity chore(v16): Remove Trade In, add CI parity, clear semgrep + lint debt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.