Swift 3 update. Other minor changes. #8
Open
jswedenburg wants to merge 5 commits intoAaron-A-zz:masterfrom
Open
Swift 3 update. Other minor changes. #8jswedenburg wants to merge 5 commits intoAaron-A-zz:masterfrom
jswedenburg wants to merge 5 commits intoAaron-A-zz:masterfrom
Conversation
Updated dictionary types to [String: Any] where needed. Also updated Array types to [[String: Any]] where needed.
After Swift 3 Update, the forecastURL was recieving optional values from the userLatitude and userLongitude. Also changed the NSError type to Error in download task.
The optional values of locality, postalCode, adminArea, and country were never actually getting unwrapped. They were remaining as optionals and displaying as optionals on screen.
|
Brilliant work jswedenburg! Thank you for these updates. I aslo think this a funproject and was having problems converting to Swift3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I thought your project looked interesting so I decided to help out. I updated to Swift 3. Once I did that there were some errors with NSDictionary and NSArray types. So I changed those to [String: Any] and [[String: Any]] respectively. Also after the Swift 3 update, the forecastURL was not working and recieving optional values from the userLatitude and userLongitude. I fixed that issue. I also changed the NSError type to Error in URLSessionDownloadTask.
Also, I noticed a bug (see screenshot) where the optional values of locality, postalCode, adminArea, and country were never actually getting unwrapped. They were remaining as optionals and displaying as optionals on screen. I fixed this as well.
This is a fun project and I hope I can keep contributing in the future. One more thing, is this available on the App Store in the US? When I followed the link, I was told it was not available in the US Store.