Add Translations - #23
Open
vlladdrakk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address #21
I have never added translations to a ubuntu touch app before, so I might be doing it wrong. I replaced all of the text with
i18n.tr()calls. The most complicated bit was the loading and error messages. The error message was inside the python file so I added aonLoadErrorevent to show a translatable message in QML. I didn't like how the loading and error messages would show up as the message id in the translation file, so I just usedloadingMessageanderrorMessageas the message id and added en_US and en_CA (for me) and added the error messages. There might be a way to do a default value, but there isn't much documentation that I could find.I'm open to input and I know it will be a while before we can merge this!