Skip to content

Enhance notebook app with sorting, daily filter, and starred notes#1

Open
Abdalla200-dot wants to merge 3 commits into
mainfrom
codex/refine-and-polish-app-features
Open

Enhance notebook app with sorting, daily filter, and starred notes#1
Abdalla200-dot wants to merge 3 commits into
mainfrom
codex/refine-and-polish-app-features

Conversation

@Abdalla200-dot

Copy link
Copy Markdown
Owner

Motivation

  • Improve note browsing and UX by adding quick list controls (sorting and daily-only) and a lightweight way to pin important notes.

Description

  • Added list controls to the notes panel: a sortBy selector (recent/oldest/title) and a Daily only toggle, and a small status line that shows note and starred counts in the header (apps/web/src/app/page.jsx).
  • Implemented localStorage-backed starred notes state (notebook_starred_notes) with toggleStarredNote and star-prioritized ordering so starred notes remain pinned across sessions (apps/web/src/app/page.jsx).
  • Updated the note list UI to allow inline star/unstar per row, preserved click-to-open behavior, and displayed note metadata (date, tags) with a cleaner row layout (apps/web/src/components/NoteList.jsx).

Testing

  • Ran dependency install with npm install --legacy-peer-deps in apps/web, which completed successfully.
  • Ran type checks with npm run typecheck, which failed due to pre-existing typing issues and missing declarations unrelated to the changes; this is a pre-existing repo issue and not introduced by this PR.
  • Launched the dev server (npm run dev -- --host 0.0.0.0 --port 4173) and captured a screenshot of the running app UI, though the environment surfaced a missing hono package warning in SSR that is external to these UI changes.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a51d4417b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +54 to +57
<div
key={note.id}
onClick={() => onSelectNote(note.id)}
className={`w-full p-3.5 mb-1.5 text-left rounded-xl transition-all group cursor-pointer ${

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep note rows keyboard-focusable

Switching each note row from a semantic button to a clickable div removes native keyboard focus and Enter/Space activation, so keyboard-only users can no longer open notes from the list. This is a functional regression from the previous implementation and affects accessibility in production; keep an interactive element here (or add equivalent keyboard handlers and focus semantics) while still using stopPropagation on the star button.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant