Enhance notebook app with sorting, daily filter, and starred notes#1
Enhance notebook app with sorting, daily filter, and starred notes#1Abdalla200-dot wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a51d4417b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div | ||
| key={note.id} | ||
| onClick={() => onSelectNote(note.id)} | ||
| className={`w-full p-3.5 mb-1.5 text-left rounded-xl transition-all group cursor-pointer ${ |
There was a problem hiding this comment.
Keep note rows keyboard-focusable
Switching each note row from a semantic button to a clickable div removes native keyboard focus and Enter/Space activation, so keyboard-only users can no longer open notes from the list. This is a functional regression from the previous implementation and affects accessibility in production; keep an interactive element here (or add equivalent keyboard handlers and focus semantics) while still using stopPropagation on the star button.
Useful? React with 👍 / 👎.
Motivation
Description
sortByselector (recent/oldest/title) and aDaily onlytoggle, and a small status line that shows note and starred counts in the header (apps/web/src/app/page.jsx).notebook_starred_notes) withtoggleStarredNoteand star-prioritized ordering so starred notes remain pinned across sessions (apps/web/src/app/page.jsx).apps/web/src/components/NoteList.jsx).Testing
npm install --legacy-peer-depsinapps/web, which completed successfully.npm run typecheck, which failed due to pre-existing typing issues and missing declarations unrelated to the changes; this is a pre-existing repo issue and not introduced by this PR.npm run dev -- --host 0.0.0.0 --port 4173) and captured a screenshot of the running app UI, though the environment surfaced a missinghonopackage warning in SSR that is external to these UI changes.Codex Task