Feat/soft delete - #659
Open
Silver36-ship-it wants to merge 9 commits into
Open
Conversation
|
@Silver36-ship-it is attempting to deploy a commit to the Abdulazeem's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
FIX FAILED CHECKS |
Owner
|
RESOLVE CONFLICTS |
Owner
|
FIX FAILED CHECKS |
Owner
|
still failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
PR Title
feat: soft delete account mappings and exclude deleted rows from lookups
Summary
This change introduces soft deletes for account federation mappings so historical audit context is preserved instead of being permanently erased when an account is unregistered or a mapping is removed.
The fix adds a nullable deleted_at timestamp to the user mapping model and updates the delete flow to set that timestamp instead of issuing a hard DELETE. All active lookup paths now explicitly filter out any rows where deleted_at is not null, preventing soft-deleted accounts from appearing in normal federation and lookup results.
What changed
Added deleted_at to the user mapping schema
Updated the unregister flow
Updated lookup and filtering behavior
Legacy/local registry safety
Why this matters
Hard deletes remove the record entirely, which destroys the historical trail for who was registered, when, and why it was removed. Soft deletes maintain the data while ensuring operational lookups, federation resolution, and account checks behave as if deleted rows do not exist.
Risk / impact
Low risk to normal operations:
Validation
The branch was created and pushed successfully:
Notes
This change intentionally keeps soft-deleted rows in storage until a separate retention/purge process removes expired entries after the configured retention window.