Hungarian brightness: relative change applied as absolute, "százalék" not read

[nledenyi]

On 1.16.0 (561c2e7), find_brightness() doesn't handle Hungarian yet. The first case is the bad one:

text	returns	effect
vedd 20%-kal halványabbra ("20% dimmer")	20	light set to 20%
kapcsold fel 40 százalékra	None	fallback
állítsd a fényerejét 40-re	None	fallback

Hungarian says "by an amount" with a suffix on the number (-kal/-kel), so _RELATIVE doesn't catch it.

This fixed all three for me, and I checked it against 11 sentences with English unchanged:

_PERCENT_WORDS += (r"százalék\w*",)  # hu
# _RELATIVE, hu:
r"|\d+\s*(?:%|százalék)-?(?:kal|kel)\b"
r"|\b(?:halványabb|világosabb|fényesebb|sötétebb)"
_LEVEL_STEMS["hu"] = ("fény", "halvány", "világos")

[nledenyi]

Thinking about it more: asking Jev for the value may be a better fix than regexes, and it would work for any language. On hosted Jev:

• brightness as a score question (10 levels, 10-100%): "40 százalékra" 40%, "hetvenre" (spelled out) 70%, "félig" 50%;
• temperature as a choice question (16-30 °C in 0.5 steps, plus none_of_these): "huszonkét és fél fok" 22.5, "19,5 fok" 19.5; "két fokkal lejjebb" and "melegebb legyen" came back none_of_these, so relative requests still go to the fallback.

Temperature options would come from each climate entity's own temperature_unit, min_temp, max_temp and target_temp_step, so °F homes work the same way (tested: "seventy four degrees" gave 74 °F, and "22 celsius" against °F options came back at confidence 0.21, which falls back).

The one gap is relative brightness ("20%-kal halványabbra" scored 80%), which would need the light's current brightness in the state.

[AboveColin]

Thanks. 1.16.1 (#36) has your százalék word and your three level stems as you wrote them. The three sentences now give None, 40 and 40, and "vedd 20 százalékkal halványabbra" also gives None.

Your bug is not only in Hungarian. I tested 52 relative sentences in 14 languages, and 45 of them set the amount as the level, such as "turn the lamp down 20%" giving 20. So I changed how Jev decides if a number is a level or an amount. It now looks at the words next to the number. A word for "to" in front of it, or the -ra/-re suffix, makes it a level. A word for "by", the -kal/-kel suffix or a comparative after it makes it an amount. Your -kal check is now one case of that rule. All 52 relative sentences now give None, and 52 other sentences, most of them levels such as "növeld a fényerőt 80%-ra", give the right answer.

Asking Jev for the value is a good idea. I agree it is the better fix, because a regex has to be written again for each language. Your temperature numbers are also useful, because climate setpoints now go to the fallback agent. I will look at a score question for brightness and a choice for the setpoint, with the options from each entity's min_temp, max_temp and target_temp_step. Relative changes will still go to the fallback, as your test showed.

If something still goes wrong after you update, a trace helps me most. In the Assist dialog, the "Jev:" note under the reply has the decision, its reason and the answers. For a satellite, the same note is in Settings, Voice assistants, the pipeline's menu, Debug. Download diagnostics on the Jev entry gives the last 20 decisions with the sentence redacted.