Skip to content

fix: intent-agnostic entity-question wording, clarify script/scene action #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AboveColin merged 2 commits into from
Sep 23, 2026
Merged

fix: intent-agnostic entity-question wording, clarify script/scene action #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4234d7
fix: intent-agnostic entity-question wording, clarify script/scene ac…
sriramsv Sep 23, 2026
c63197d
address review: shorten turn_on wording, trim comment, no em dashes
sriramsv Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions custom_components/jev/interpret.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ def build_questions(
# No lock wording here on purpose. The agent does not control
# locks, and Home Assistant's on/off convention for them runs the
# opposite way round from speech. See CONTROLLABLE in snapshot.py.
"turn_on": "Switch something on, open it, or start it",
"turn_on": "Switch something on, open it, start it, "
"or run a script or scene",
"turn_off": "Switch something off, close it, or stop it",
"toggle": "Flip whatever state it is in now",
"set_brightness": "Change how bright a light is",
Expand Down Expand Up @@ -194,7 +195,9 @@ def build_questions(
),
"entity": Choice(
{
"question": "Which device should receive this?",
# Answered in the same request as action, so it must fit a
# status check too.
"question": "Which device is this about?",
"background": "Match on the name and on the room. Pick "
"none_of_these when no single device is meant.",
},
Expand Down
Loading