A voice command that acts says what it did - #28
Merged
Merged
Conversation
Jev ran the action through the intent layer, which says nothing, and the Assist dialog showed no reply at all. Home Assistant's own agent picks a sentence from home-assistant-intents by what the command targeted. Jev now reads the same key off the slots it sent and renders that sentence, and says "Done." where the package has none, as for a toggle.
# Conflicts: # custom_components/jev/conversation.py # tests/test_conversation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jev ran an action through the intent layer, which sets no speech, so the Assist dialog showed no reply and a satellite said nothing. Home Assistant's own agent picks a sentence from home-assistant-intents by what the command targeted. Jev now reads the same response key off the slots it sent and renders that sentence in the pipeline's language, such as "Turned on the light". Where the package has no sentence, as for a toggle, it says "Done."
This changes what existing users hear: an action that was silent now speaks one sentence.
Tests:
test_an_action_says_what_the_default_agent_says,test_an_action_with_no_sentence_of_its_own_says_done,test_a_brightness_command_says_it_was_set.Local gate: ruff, ruff format, mypy --strict, pytest (417 passed), config_flow 100%, mkdocs --strict, hassfest. EXIT 0.