"Turn off all the lights" counts as every device of one kind - #29
Merged
Merged
Conversation
The everything option read "The whole house, with no room or device named". For "turn off all the lights" the model put 0.44 to 0.52 on it, below the 0.6 floor, and the command fell back. With the option naming every device of one kind, "all the lights", "every light" and "the lights" acted 6 of 6 times live. Commands naming an exposed device or a room still named it, 8 of 8, and "turn on all the lights" was still refused by the whole-house gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
everythingoption of the target question read "The whole house, with no room or device named". For "turn off all the lights" the model put 0.44 to 0.52 on it, below the 0.6 floor, and the command went to the fallback agent.The option now names every device of one kind as well. Measured on a development instance: "all the lights", "every light" and "the lights" acted 6 of 6 times. Commands that name an exposed device or a room still named it, 8 of 8. "Turn on all the lights" is still refused by the whole-house option when that option is off.
This is a one-line change to the option text, so no test covers it. The receipts above are the check.
Local gate: ruff, ruff format, mypy --strict, pytest (407 passed), config_flow 100%, mkdocs --strict, hassfest. EXIT 0.