Repository navigation
Fix two errors that stop the extension building from source - #59
Merged
Merged
Conversation
main does not compile. The _C.so in a working tree is older than the sources it was
built from, so an incremental developer never sees it -- only a clean build on
another machine does, which is where this surfaced.
reduction_aggr.cu's light-node kernel computes its index inside the bounds check and
then subscripts with `i`, which is declared nowhere:
if (static_cast<size_t>(blockIdx.x) * blockDim.y + threadIdx.y >= num_light) return;
const index_t v = light_nodes_indices[i];
No toolkit accepts that. The guard's own expression is the index, so name it.
adaptive_ops.cuh calls cuda::std::log, exp and fma without including
<cuda/std/cmath>. CUDA 12.9's libcu++ provides them transitively and the omission is
invisible; on 12.2 every translation unit that includes the header fails with
"namespace cuda::std has no member log" -- five of the seven in a full build.
Verified by compiling reduction_aggr.cu, which hit both, for sm_80.
Worth following up separately: nothing in CI builds the extension, so compilation can
break and stay broken for a week.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Abusagit
approved these changes
Sep 11, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.