Add test for recurring disbursement failure without mutating schedule… - #546
Merged
thegreatfeez merged 1 commit intoAug 31, 2026
Merged
Conversation
… on insufficient balance
|
@akprinciple is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@akprinciple Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #448
Guard recurring disbursements against insufficient balance before state mutation
Summary
This PR ensures recurring disbursements fail early with the existing
TransferFailederror variant before mutating any schedule state when the contract treasury lacks sufficient token balance to cover the scheduled disbursement period.Changes
disburse_recurringprior to initiating the token transfer.Error::TransferFailedimmediately if the contract treasury balance is lower than the scheduled amount.TransferFailederror variant defined in the contract error enum.Why
Previously, the recurring disbursement flow could progress toward the transfer operation without validating available treasury liquidity. In low-balance scenarios, the transaction could abort after entering a state-mutation path, risking schedule state corruption and inconsistent accounting.
This pre-check ensures strict check-effects-interactions safety and protects schedule state integrity.
Validation
Added a targeted regression test verifying behavior under insufficient contract balance:
Error::TransferFailedis returned deterministically.last_disbursed_at,total_disbursed, andperiods_disbursedremain completely unchanged.