Fix proposal ready weighted quorum - #551
Merged
thegreatfeez merged 2 commits intoAug 31, 2026
Merged
Conversation
|
@Peolite1 is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Peolite1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the optimistic update logic in the Dashboard to correctly derive a proposal's "Ready" status using weighted quorum. Previously, the app calculated readiness by adding 1 to a flat approval count and comparing it against the threshold, causing the frontend to momentarily disagree with the contract state (which computes readiness based on cumulative voting weight vs quorum weight).
The
approveandrevokehandlers inApp.tsxnow correctly add or subtract the connected owner's voting weight and determine the status by comparing the updatedapprovalWeightagainst the proposal'squorumWeight.Type of Change
Related Issue
Closes #395
Testing Checklist