Skip to content

Fix proposal ready weighted quorum - #551

Merged
thegreatfeez merged 2 commits into
Ac0rdP:mainfrom
Peolite1:fix-proposal-ready-weighted-quorum
Aug 31, 2026
Merged

Fix proposal ready weighted quorum#551
thegreatfeez merged 2 commits into
Ac0rdP:mainfrom
Peolite1:fix-proposal-ready-weighted-quorum

Conversation

@Peolite1

Copy link
Copy Markdown
Contributor

Summary

This PR updates the optimistic update logic in the Dashboard to correctly derive a proposal's "Ready" status using weighted quorum. Previously, the app calculated readiness by adding 1 to a flat approval count and comparing it against the threshold, causing the frontend to momentarily disagree with the contract state (which computes readiness based on cumulative voting weight vs quorum weight).

The approve and revoke handlers in App.tsx now correctly add or subtract the connected owner's voting weight and determine the status by comparing the updated approvalWeight against the proposal's quorumWeight.

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor

Related Issue

Closes #395

Testing Checklist

  • Existing tests pass locally
  • New tests added to cover this change (where applicable)
  • Manually verified the change works as expected
  • Lint / type checks pass

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@Peolite1 is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@Peolite1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@thegreatfeez
thegreatfeez merged commit 2236d3b into Ac0rdP:main Aug 31, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ProposalCard to derive "Ready" status from weighted quorum rather than a raw approval count, updating the optimistic-update logic accordingly

2 participants