feat: display raw stroop amount alongside human-readable amount in ProposalCard - #559
Open
Nuruddeen61 wants to merge 3 commits into
Open
feat: display raw stroop amount alongside human-readable amount in ProposalCard#559Nuruddeen61 wants to merge 3 commits into
Nuruddeen61 wants to merge 3 commits into
Conversation
Added rawAmount field to Proposal type and updated amount comment.
|
@Nuruddeen61 is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Displays the raw stroop value alongside the human-readable token amount (XLM/USDC) in ProposalCard for transfer and spending limit proposals.
Motivation
Issue #4 - Users need to verify the exact raw amount before signing transactions on Soroban. Currently only the formatted amount is shown.
Changes
frontend/src/components/ProposalCard.tsx: AddedrawAmountdisplay intransfercasefrontend/src/components/ProposalCard.tsx: AddedrawAmountdisplay inset_spending_limitcaserawAmountexists and is not "-"Example
Before:
Send 50 USDC
To GABC...
After:
Send 50 USDC
Raw: 50000000 stroops
To GABC...
Closes
Closes #4