feat(accord): add token validation to recurring proposal entrypoint - #560
Open
Musab1258 wants to merge 1 commit into
Open
feat(accord): add token validation to recurring proposal entrypoint#560Musab1258 wants to merge 1 commit into
Musab1258 wants to merge 1 commit into
Conversation
Adds `validate_token(&env, &token)?` to `create_recurring_proposal` at line 2726 to ensure the proposal asset is legitimate. This completes the required validation suite for recurring proposals, aligning it with existing checks: - amount bounds check - interval duration check - contract self-recipient restriction - token address validation (new) The implementation mirrors the proven validation patterns found in `create_proposal` and `create_recurring_schedule`. Pre-existing compilation errors in the contract are unrelated to this change.
|
@Musab1258 is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Musab1258 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not done with this, but when completed:
Fixes #439
Fixes #435
Fixes #438
Fixes #437