Skip to content

New API Set (Version 1.x) for PBU based decoding#218

Merged
kpchoi merged 36 commits into
mainfrom
oapv_api_ver2
Jul 6, 2026
Merged

New API Set (Version 1.x) for PBU based decoding#218
kpchoi merged 36 commits into
mainfrom
oapv_api_ver2

Conversation

@kpchoi

@kpchoi kpchoi commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Added new API set to support PBU based decoding

  • New API introduces new decoding features;
    • PBU based decoding
    • Partial decoding indexed by Tile ID
  • Note: New API doesn't support additional encoding features
  • Note: Major version number is increased to v1.0.0.0

kpchoi and others added 30 commits March 3, 2026 17:27
@kpchoi
initial code
2a3291d 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
Merge remote-tracking branch 'origin/main' into apv_raw
d399fc7
@kpchoi
need to add companding functionality
0d785d1 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
refactoring
c4028b3 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
Merge remote-tracking branch 'origin/main' into apv_raw
13cafc8
@kpchoi
maybe working code
013d0d6 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
added new c file
ef0809f 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
changed profile name
b8dc9a4 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
changed profile idc and added use_companding syntax
39f34d6 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
initial commit for decoder
a03d203 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
fixed bug in colorspace setting
906c56b 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
refactoring blk code
2d89a12 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
fixed for P210 format
bf59009 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@mss-park
clean up blk_from_pic
5bc6c75 
Signed-off-by: Minsoo Park <mss.park@samsung.com>
@mss-park
modification of blk_from_pic
12a5e54 
Signed-off-by: Minsoo Park <mss.park@samsung.com>
@kpchoi
Merge remote-tracking branch 'origin/main' into apv_raw
f6eca1a
@subhrajitm20
separate functions for companding and no-companding (#198)
d88480e 
Signed-off-by: subhrajitm20 <2003subhrajit@gmail.com>
@kpchoi
Merge branch 'apv_raw' of https://github.com/AcademySoftwareFoundatio…
49c6139 
…n/openapv into apv_raw
@kpchoi
initial code
76580b8 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
adding PDU level decoding
d1dfdab 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
fixed typo
1cbcd92 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
frame level decoding is working now
a9fa6ce 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
added partial decoding API
e58f681 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
refactoring
9611950 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
refactoring
9368cf3 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
fixed for decoding tiles
e23de74 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
added command line option for testing tile-based decoding
30154fc 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
fixed memory leak
6496eaa 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
inrease version to 1.0.0.0
840807f 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
merged with main
d4d9cb8 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
kpchoi added 2 commits June 30, 2026 15:50
@kpchoi
refactoring and fuzzing defense code
ece1f65 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
add fuzzing defense code
73d8566 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi kpchoi requested review from mss-park and tuzm24 June 30, 2026 08:44
@kpchoi
fuzzing protection code
5da7690 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi kpchoi requested a review from ssantihub July 3, 2026 00:49
@kpchoi
changed to use the safe string parser
0c654e8 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
ssantihub
ssantihub approved these changes Jul 3, 2026
View reviewed changes

@ssantihub ssantihub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Looks good to me. Cheers.

mss-park
mss-park approved these changes Jul 3, 2026
View reviewed changes

@mss-park mss-park left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

tuzm24
tuzm24 approved these changes Jul 3, 2026
View reviewed changes

@tuzm24 tuzm24 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@creata96 creata96 self-requested a review July 3, 2026 05:38
creata96
creata96 approved these changes Jul 3, 2026
View reviewed changes

@creata96 creata96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lordnn
lordnn reviewed Jul 4, 2026
View reviewed changes
Comment thread app/oapv_app_dec.c

#define MAX_BS_BUF 128 * 1024 * 1024 /* byte */
#define MAX_BS_BUF 128 * 1024 * 1024 /* byte */
#define MAX_NUM_METADATA_PLDS 128 /* max number of metadata payloads per access unit */

@lordnn lordnn Jul 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this used anywhere?

@kpchoi kpchoi Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max number of metadata payload is defined in decoder app, but hardcoded value '128' was used instead of the predefined macro.
It is changed to MAX_NUM_METADATA_PLDS for now.
Thanks for information.

kpchoi added 2 commits July 6, 2026 09:31
@kpchoi
add error handling code
89838e3 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi
changed to predefined value MAX_NUM_METADATA_PLDS
3400808 
Signed-off-by: kp5.choi@samsung.com <kp5.choi@samsung.com>
@kpchoi kpchoi merged commit 92ffa74 into main Jul 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssantihub ssantihub ssantihub approved these changes
@tuzm24 tuzm24 tuzm24 approved these changes
@mss-park mss-park mss-park approved these changes
@creata96 creata96 creata96 approved these changes
+1 more reviewer
@lordnn lordnn lordnn left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kpchoi @lordnn @ssantihub @tuzm24 @mss-park @creata96 @subhrajitm20