feat(timeline): add keyboard and scroll panning support#777
feat(timeline): add keyboard and scroll panning support#777TimeToBuildBob wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 34f6a74 in 20 seconds. Click for details.
- Reviewed
31lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_9EkIOUlmTfFf0nlr
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Enable horizontal scroll/swipe panning and keyboard navigation (arrow keys to pan, +/- to zoom) using vis-timeline's built-in options. Vertical scroll still zooms as before. Supersedes ActivityWatch#535. Closes ActivityWatch#629
34f6a74 to
3164ae0
Compare
Greptile SummaryEnhanced timeline navigation by enabling vis-timeline's built-in keyboard and scroll features. Changes the default scroll behavior from zoom to horizontal pan (zoom now requires Ctrl+scroll), adds arrow key panning, and +/- zoom shortcuts.
Clean implementation using native vis-timeline options (v7.5.0) with no custom event handling needed. Addresses issue #629. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 3164ae0 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #777 +/- ##
=======================================
Coverage 25.71% 25.71%
=======================================
Files 30 30
Lines 1750 1750
Branches 307 320 +13
=======================================
Hits 450 450
+ Misses 1278 1234 -44
- Partials 22 66 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
horizontalScroll: truekeyboard: { enabled: true }All features use vis-timeline's built-in options — no custom event handling needed.
Supersedes #535 (which only adds
horizontalScroll; this PR also adds keyboard navigation).Closes #629
Test plan