Add bond thickness setting#85
Draft
mimvoid wants to merge 1 commit into
Draft
Conversation
Acylation
added
category/new feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the bond thickness for RDKIt to be the same as for Smiles Drawer, and adds a bond thickness option in the Setting Tab.
Currently, Smiles Drawer has a
bondThicknessof1by default, but RDKit does not havebondLineWidthset. So, RDKit looks much thicker than Smiles Drawer. I believe setting RDKit'sbondLineWidthto also be1is more consistent and readable. The user can then customize this for both render cores.This pull request is mostly done, but there are some things I haven't finalized.
Where in the settings should bond thickness be? I put it in the Advanced section for now, but it could also be next to themes. Or could there be a new Appearance section for minor settings like bond thickness, short bond length, font size, legend font size, etc.?
Also, I haven't sorted out the Chinese localization.