build(deps-dev): bump @types/node to 26.0.0#146
Closed
jasonodoom wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Holding this back. @types/node 26 makes Uint8Array generic with an ArrayBufferLike default (including SharedArrayBuffer), which is no longer assignable to BufferSource at the WebCrypto boundary, so the package build (tsc -p tsconfig.build.json) fails in src/crypto/ink.ts. Bringing the crypto module to the generic Uint8Array types is a focused migration with its own tests and review, not part of a routine dev-dependency bump. Staying on @types/node 24 until then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major bump of the root @types/node dev-dependency (supersedes #137), with the nix npm-deps hash refreshed for the new lockfile. typecheck passes, npm reports 0 vulnerabilities, and
nix build .#cli .#defaultsucceeds locally.