Skip to content

Danielle_Metzner_Ride-Share.rb#29

Open
danimetz wants to merge 1 commit into
Ada-C10:masterfrom
danimetz:master
Open

Danielle_Metzner_Ride-Share.rb#29
danimetz wants to merge 1 commit into
Ada-C10:masterfrom
danimetz:master

Conversation

@danimetz

@danimetz danimetz commented Aug 13, 2018

Copy link
Copy Markdown

ride share

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? I set it up originally with the hash of drivers and an array of hashes that included the rides
What was your strategy for going through the data structure and gathering information? Looping through the hash for each driver and then the rides for each driverand creating a new hash that stored the specified information (value) for each driver
What was an example of something that was necessary to store in a variable? What was the scope of each of that variables? Why? The hash of dates and total money made. This allowed the max value to be returned for each driver in the loop and starting fresh for each driver
What kinds of iteration did you use? Did you use .map? No, each loops.
Were some calculations easier than others? Why? Yes, ones that only involved summing or counting

@dHelmgren

Copy link
Copy Markdown

Your data is laid out really well, and I appreciate your structuring of the code itself. I did notice a few times when you could have used enumerables other than .each, so now that we've had more practice you might look over what you did here and theorize how you could improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants