Create Goeun - Rideshare - Edges.rb#33
Open
goeunpark wants to merge 1 commit into
Open
Conversation
|
Great work overall! Your data structure feels like a very natural choice for this problem. I also appreciate the way you broke your code out into separate methods - this makes the flow of the program much easier to follow. Keep up the hard work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ride share
Congratulations! You're submitting your assignment.
Comprehension Questions
most_money()andbest_rating(), I use variablesgreatestandindexto compare the sum cost / average rating and its location within the arrays I created specifically for these methods. The scope of these variables are limited to within the method because these variables help me find therichest_driverandbest_ranked_driverwhich is the information I ultimately want and I don't need them outside of the method..map?