Layla_Edges_Rideshare#41
Open
lbristol88 wants to merge 3 commits into
Open
Conversation
|
Good work overall! I like that the loop you used to find the numbers for the different drivers is separate from the loop you used to print the results. As our logic becomes more and more complex, separating display logic from business logic will be an important technique. You also did a good job of breaking your code out into methods, which is good for readability. One nitpick: your calculation of the average rating uses integers, so you loose a little precision when you divide. However, in general I am quite happy with this submission. Keep up the hard work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ride share
Congratulations! You're submitting your assignment.
Comprehension Questions
.map?