Skip to content

Pushpa_Agr_EdgesC10_Rideshare#45

Open
pushpaagr wants to merge 1 commit into
Ada-C10:masterfrom
pushpaagr:master
Open

Pushpa_Agr_EdgesC10_Rideshare#45
pushpaagr wants to merge 1 commit into
Ada-C10:masterfrom
pushpaagr:master

Conversation

@pushpaagr

Copy link
Copy Markdown

ride share

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? My data structure first looked like one hash, and then it evolved into an hash with array with hashes.
What was your strategy for going through the data structure and gathering information? My strategies was to make sure that my data structure would be able to be accessible by driver's information
What was an example of something that was necessary to store in a variable? What was the scope of that variable? Why? I had to create variable for most_money, max_driver, and most_rating and the scope of that was within my method that was accessible throughout the code
What kinds of iteration did you use? Did you use .map? I used .each for my iteration and did not use .map
Were some calculations easier than others? Why? Yes getting the total amount per driver was much easier then calculating the max of the drivers. Individual information was easier to gather than comparing all the data with other driver's data

@droberts-sea

Copy link
Copy Markdown

Good work overall! I like your choice of data structure - it feels like a natural way to store this information.

I do have a couple pieces of feedback:

  • You should break your data structure across multiple lines. My general rule is one key-value pair per line. This will make it much easier to read, and to notice missing or bad data.
  • I like that you've wrapped your code in a method, but I think there's an opportunity to break it out even further. For example, you might have a method that finds the average rating for each driver, and another to find who made the most money. In general, each method should do one thing.

Overall I'm quite happy with this submission. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants