Ports - Heather#15
Open
piffer59 wants to merge 1 commit into
Open
Conversation
pmanni02
reviewed
Apr 30, 2019
pmanni02
left a comment
pmanni02
left a comment
There was a problem hiding this comment.
Looks good overall 👍 If you wanted to refactor/DRY this up further think about ways you can capture the edge case of number ==0 without explicitly checking for it.
| raise NotImplementedError | ||
| total = number | ||
| if number == nil | ||
| raise ArgumentError, "number is nil" |
There was a problem hiding this comment.
While this works for this fn because factorial is a known concept in math, I would rethink the message. For example, number cannot be nil or input cannot be nil. These messages tell the user what the input is and why an error was thrown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.