Ports - Kim#25
Open
Kimberly-Fasbender wants to merge 1 commit into
Open
Conversation
ace-n
approved these changes
Apr 14, 2019
ace-n
left a comment
ace-n
left a comment
There was a problem hiding this comment.
LGTM, other than a tiny nit. Nice work! 👍
| # Space complexity: O(1) constant - input size does not affect space | ||
| def factorial(number) | ||
| raise NotImplementedError | ||
| if !number |
There was a problem hiding this comment.
Tiny nit: is it worth adding a similar "guarding if" for number < 0?
ace-n
reviewed
Apr 14, 2019
| # Computes factorial of the input number and returns it | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) linear - where n is the input number - 2 |
There was a problem hiding this comment.
One more tiny nit: the - 2 is redundant here. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.