Branches - C. Gutierrez#28
Open
CEsGutierrez wants to merge 1 commit into
Open
Conversation
…ts re. space and time complexities
CheezItMan
reviewed
Sep 10, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall not bad. Check out my comments. I'm uncertain why you had the 21.times loops in your code. That puzzled me. You also had some issues with Big-O. Check out my comments and let me know if you have questions.
| raise NotImplementedError | ||
| i = 0 | ||
| length = 0 | ||
| 21.times do |
| # Space complexity: constant, no variables are stored in memory. | ||
| def print_array(array) | ||
| raise NotImplementedError | ||
| 21.times do |
| # Reverses the values in the integer array in place | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: quadratic, the array is iterated through twice, so as it gorws, the time required to process it would grow twice as much. |
There was a problem hiding this comment.
Since the loops are not nested, and each loop runs n times. The time complexity is O(n)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.