Leaves - Yitgop#42
Open
rinostar wants to merge 4 commits into
Open
Conversation
CheezItMan
reviewed
Sep 10, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad, you hit the main learning goals here. Well done. Check out my comments and let me know if you have questions.
| while n < length | ||
| if value_to_find == array[n] | ||
| return true | ||
| found += 1 |
| n += 1 | ||
| end | ||
|
|
||
| if found == 0 |
There was a problem hiding this comment.
You can simply return false if this line is encountered, there's no need for an if statement.
| mid = (low + high)/2 | ||
| if array[mid] == value_to_find | ||
| return true | ||
| found += 1 |
There was a problem hiding this comment.
Since you are returning this line will never execute.
| end | ||
| end | ||
|
|
||
| if found == 0 |
There was a problem hiding this comment.
This has the same problem as linear search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.