Branches-Steph#48
Open
Steph0088 wants to merge 3 commits into
Open
Conversation
CheezItMan
reviewed
Dec 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
I'm glad you got this in. A few minor mistakes in a few of the methods here. Take a look at my suggestions and let me know if you have questions.
| # Space complexity: O(1) | ||
| def binary_search(array, length, value_to_find) | ||
| raise NotImplementedError | ||
| bigger = array.length - 1 |
There was a problem hiding this comment.
In restricted Array, length is not a method. It's a parameter passed in.
Suggested change
| bigger = array.length - 1 | |
| bigger = length - 1 |
| bigger = array.length - 1 | ||
| smaller = 0 | ||
| while bigger >= smaller | ||
| middle = (high + low) / 2 |
There was a problem hiding this comment.
You need to define high and low here before the loop starts. Maybe use smaller and bigger.
Suggested change
| middle = (high + low) / 2 | |
| middle = (bigger + smaller) / 2 |
| while i < length | ||
| if array[i] < smallest | ||
| smallest = array[i] | ||
| i += 1 |
There was a problem hiding this comment.
You don't want to do this twice in the while loop.
Suggested change
| i += 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.