Branches - Kelsey#34
Conversation
|
|
||
|
|
||
| <section> | ||
| <section class="quote"> |
There was a problem hiding this comment.
Good job on re-using classes for these blockquotes! This achieves DRY'er code.
| @@ -0,0 +1,54 @@ | |||
| @media only screen and (max-width: 630px) { | |||
There was a problem hiding this comment.
I like that you implemented something new that wasn't specifically mentioned in the project requirements (but could be inferred since they provided us with a wireframe for desktop and mobile). Super clever!
| margin: 61px; | ||
| } | ||
|
|
||
| /* QUOTES */ |
There was a problem hiding this comment.
Good job on adding comments for signposting. This is helpful for my review.
| .tellmewhy img { | ||
| display: none; | ||
| } | ||
| .tellmewhy ul li { |
There was a problem hiding this comment.
I would consider adding some comments for sign-posting, like you did in your styles.css. This would help me understand what elements are being changed from your website without having to reference the html.
| padding: 0 5em 0 5em; | ||
| text-align: right; | ||
| } | ||
| nav ul li:first-child { |
| border-bottom: none; | ||
| } | ||
| .team ul { | ||
| display: grid; |
There was a problem hiding this comment.
Super cool you made this into a grid. I had trouble doing this myself, and chose a flexbox. It's cool you got this to work!
| align-items: center; | ||
| } | ||
|
|
||
| /* SUPPORT */ |
There was a problem hiding this comment.
We already chatted about this, but I would consider changing the name of your class to make it more clear that it is formatting both the support and about section. Otherwise, good job!
| grid-template: 1fr / 1vw 55vw 15vw 15vw; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
This is minor (your code is so good that I'm looking for things to critique).. but I would consider cleaning up your extra spaces to make the file nice and clean to read. I think single spaces might be enough to make it readable.
2 participants
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions