Leaves - Julia K#49
Conversation
| } | ||
|
|
||
| nav { | ||
| font-size: .9em; |
There was a problem hiding this comment.
Good use of relative units for fonts.
| width: 100%; | ||
| margin: 1 1rem; | ||
| padding: 20px; | ||
| transform: translateY(-1rem); |
There was a problem hiding this comment.
Very cool! I've never heard of this before!
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <link href="styles/styles.css" rel="stylesheet"> |
There was a problem hiding this comment.
I think normalize is supposed to be on top of stylesheet to help avoid cascading conflict style issues?
| <section> | ||
| <div class="blockquote"> | ||
| <blockquote> | ||
| <div class="quote"> |
There was a problem hiding this comment.
Good use of classes to double-dip CSS styling to make it apply to both sections!
| @@ -0,0 +1,177 @@ | |||
| @import url('https://fonts.googleapis.com/css?family=Roboto+Condensed:300i&display=swap'); | |||
There was a problem hiding this comment.
Hmmm. Totally different from how I did it but works well! Good job!
|
Good job overall. I am impressed by your use of classes as they will scale well with multiple sections that are supposed to share properties. A possible improvement might be to use more descriptive class names to make the code easier to read, but that's purely an opinion. Well done!! :) |
2 participants
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions