Time - Corinna#35
Open
corinna-fab wants to merge 61 commits into
Open
Conversation
…ated user controller for index
…lay if temperatures aren't included in the pizza entry
…mperature dropdown if no temperature has been provided and updated top pizza page
…pdated seeds accordingly
beccaelenzil
reviewed
Jun 3, 2020
beccaelenzil
left a comment
beccaelenzil
left a comment
There was a problem hiding this comment.
Great job overall! Your implementation matches the demo site very closely, and the learning goals for this assignment were definitely met. I've left a few in-line comments for you to review. I love that you made it your own. Yummmm pizza. Keep up the hard work!
| <table class="table"> | ||
| <thead> | ||
| <tr> | ||
| <th width="80">Votes</th> |
There was a problem hiding this comment.
You have the same code to show a list of works repeated 3 times. Could you use a view partial or a loop to DRY this up?
| end | ||
|
|
||
| def show | ||
| pizza_id = params[:id] |
There was a problem hiding this comment.
consider adding a controller filter find_pizza to DRY up your code.
Comment on lines
+82
to
+86
| if @pizza.vote_count.nil? | ||
| @pizza.vote_count = 1 | ||
| else | ||
| @pizza.vote_count += 1 | ||
| end |
There was a problem hiding this comment.
Consider moving these few lines of logic into a custom model method.
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?