Space - Hala#43
Open
halahaddad1 wants to merge 15 commits into
Open
Conversation
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
beccaelenzil
reviewed
Jun 5, 2020
beccaelenzil
left a comment
beccaelenzil
left a comment
There was a problem hiding this comment.
Great work on this assignment. Your code is clear and well written, and it is clear that the learning goals were met. Your models are very well tested. I've let a few in-line comments focused on ways you could DRY up your code with partial views and controller filters. Please let me know if you have any questions. Keep up the hard work!
| </div> | ||
| </div> | ||
|
|
||
| <div class="row flex-nowrap"> |
There was a problem hiding this comment.
You essentially have the same code repeated three times. Consider how you could use a partial view or a loop to DRY up this code.
| </thead> | ||
| <tbody> | ||
| <h3> Top Albums </h3> | ||
| <% Work.albums_list.each do |work| %> |
There was a problem hiding this comment.
As above, you essentially have the same code repeated 3 times. Consider how you may dry up this code, including modifying your model method to take the category as an argument.
| return Work.all.max_by { |work| work.votes.count } | ||
| end | ||
|
|
||
| def self.movies_list |
There was a problem hiding this comment.
Consider how you could DRY up this code by using the category as an argument.
def self.sorted_list(category)
| end | ||
|
|
||
| def destroy | ||
| @work = Work.find_by(id: params[:id]) |
There was a problem hiding this comment.
Note that you need to find a work in multiple actions. This would be great functionality to put into a controller filter.
| expect(@spotlight_media).must_be_instance_of Work | ||
| expect(@works.max_by { |work| work.votes.count }).must_equal @spotlight_media | ||
| end | ||
|
|
There was a problem hiding this comment.
Consider including another test for what happens if two works are tied.
| end | ||
|
|
||
| describe "relationships" do | ||
| it "has relationships with Work and User" do |
There was a problem hiding this comment.
Consider breaking this into 2 tests since it is 2 different relationships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?